No need to call _copy_overlapping if src and dst address same memory #1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandr-pavlyk
requested review from
AlexanderKalistratov,
antonwolfy and
npolina4
|
Shouldn't it also fix sqrt with 'out' for pairwise distance? |
AlexanderKalistratov
approved these changes
Jul 17, 2023
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1284/index.html |
```
In [1]: import dpctl.tensor as dpt, dpctl, dpctl.utils
In [2]: n, m = 8 * 540, 8 * 960
In [3]: a = dpt.ones((m, n))
In [4]: b = dpt.zeros((m, n))
In [5]: b_s = dpt.zeros((m, n+2))
In [6]: with dpctl.utils.onetrace_enabled():
...: b_s[:,:-2] += a
...:
Device Timeline (queue: 0x556080b9cea0): zeCommandListAppendMemoryCopy(H2D)[48 bytes]<4.1> [ns] = 16946404661 (append) 16952292497 (submit) 16952613747 (start) 16952623538 (end)
Device Timeline (queue: 0x556080b9cea0): dpctl::tensor::kernels::add::add_inplace_strided_kernel<float, float, dpctl::tensor::offset_utils::TwoOffsets_StridedIndexer>[SIMD32 {64800; 1; 1} {512; 1; 1}]<5.1> [ns] = 17017855801 (append) 17018342202 (submit) 17019138920 (start) 17030770482 (end)
```
Earlier, two more copy operations were being performed as well.
oleksandr-pavlyk
force-pushed
the
improve-overlap-check-in-copy
branch
from
17a2623 to
701c05b
Compare
|
Array API standard conformance tests for dpctl=0.14.5dev1=py310h7bf5fec_11 ran successfully. |
1 similar comment
|
Array API standard conformance tests for dpctl=0.14.5dev1=py310h7bf5fec_11 ran successfully. |
AlexanderKalistratov
approved these changes
Jul 17, 2023
npolina4
approved these changes
Jul 17, 2023
antonwolfy
approved these changes
Jul 17, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.5dev1=py310h7bf5fec_11 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier, two more copy operations were being performed as well.
Previously:
Now: